Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): add --ignore-tags argument #696

Merged
merged 15 commits into from
Jun 17, 2024
Merged

Conversation

bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 13, 2024

Description

This adds --ignore-tags argument to cli.

How Has This Been Tested?

I included fixture based tests but - this fixture won't pass - because of this line
I am not sure if this is intended - I would expect this to work (not requiring a commit to recognize 1.0.0 version) - need more info.
If this is intended then simply need to uncomment this line.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bukowa bukowa requested a review from orhun as a code owner June 13, 2024 23:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.18%. Comparing base (dabe716) to head (969b884).
Report is 1 commits behind head on main.

Files Patch % Lines
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   36.29%   36.18%   -0.11%     
==========================================
  Files          19       19              
  Lines        1455     1457       +2     
==========================================
- Hits          528      527       -1     
- Misses        927      930       +3     
Flag Coverage Δ
unit-tests 36.18% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bukowa

This comment was marked as outdated.

.github/fixtures/test-fixtures-locally.sh Outdated Show resolved Hide resolved
.github/fixtures/test-fixtures-locally.sh Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
git-cliff/src/args.rs Outdated Show resolved Hide resolved
website/docs/usage/args.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@bukowa bukowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main I hope its ok. I can revert if needed.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orhun orhun changed the title feat(cli,args): add --ignore-tags argument to cli feat(args): add --ignore-tags argument Jun 17, 2024
@orhun orhun merged commit 94891c2 into orhun:main Jun 17, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants