Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog): make remote data available in context #703

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Jun 15, 2024

Description

This PR updates the changelog processing order to make remote data (e.g. GitHub commits, pull requests, etc.) available in the context.

Motivation and Context

git cliff --github-repo orhun/git-cliff -c examples/github.toml -x --no-exec -u

This command will now contain the GitHub data such as:

 "github": {
      "contributors": [
        {
          "username": "bukowa",
          "pr_title": "style(lint): fix formatting",
          "pr_number": 702,
          "pr_labels": [],
          "is_first_time": true
        },
    ],
}

Might fix #687

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 37.15%. Comparing base (b7e323f) to head (5368988).

Files Patch % Lines
git-cliff-core/src/changelog.rs 83.79% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   36.89%   37.15%   +0.27%     
==========================================
  Files          18       18              
  Lines        1350     1354       +4     
==========================================
+ Hits          498      503       +5     
+ Misses        852      851       -1     
Flag Coverage Δ
unit-tests 37.15% <83.79%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit d14774a into main Jun 15, 2024
43 of 44 checks passed
@orhun orhun deleted the feat/make_remote_fields_available_in_context branch June 15, 2024 15:05
@orhun orhun mentioned this pull request Jun 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab context data are missing
2 participants