-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelog): add tag message to release context #713
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 36.52% 36.67% +0.16%
==========================================
Files 19 19
Lines 1468 1489 +21
==========================================
+ Hits 536 546 +10
- Misses 932 943 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks good at first glance, I can add a proper review if you can fix the CI & polish the implementation 🐻 |
334931c
to
bd79b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I had some comments.
Can you also add a little documentation under website/docs/usage/adding-tag-messages.md
?
- add to the release context the tag's message if it exists - add message to the default config
to allow setting the message of the last release in the context
1f41a6d
to
ec5d2a9
Compare
Thanks! added the docs: eafe9b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, TYSM!
Thanks everybody for implementing this! |
When will this feature be updated to git-cliff-action? |
I don't use the github action (I use gitlab) so I'm not 100% sure. But, I guess it's already there and all you need is to use the |
Just updated |
Description
added to the release context the tag's message if it exists
Motivation and Context
closes #623
How Has This Been Tested?
Screenshots / Logs (if applicable)
Types of Changes
Checklist: