Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add cliff-jumper to similar projects #83

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

favna
Copy link
Contributor

@favna favna commented Apr 18, 2022

Description

I recently finished @favware/cliff-jumper, which is exactly what is described in the change. Not entirely sure what the definition of "Similar project" is, but I figured "hey nothing ventured, nothing gained". If a package like this does not meet the requirements for "Similar project" then no harm done rejecting this PR.

Motivation and Context

N.A., readme only.

How Has This Been Tested?

N.A., readme only.

Screenshots / Output (if appropriate):

N.A., readme only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project. (I think so? Not entirely sure what the markdown formatting is that was applied on readme, I guessed a prose wrap and line length of 120)
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Honestly not entirely sure what the definition of a "similar project" is but I figured I'd give it a shot adding this as I recently finished it.
@favna favna requested a review from orhun as a code owner April 18, 2022 13:46
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #83 (8438dd0) into main (9801963) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   38.96%   38.96%           
=======================================
  Files          14       14           
  Lines         901      901           
  Branches      233      234    +1     
=======================================
  Hits          351      351           
  Misses        440      440           
  Partials      110      110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9801963...8438dd0. Read the comment docs.

Co-authored-by: Orhun Parmaksız <[email protected]>
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool project, thanks! 🐻

@orhun orhun changed the title docs(readme): add @favware/cliff-jumper package docs(readme): add cliff-jumper to similar projects Apr 18, 2022
@orhun orhun merged commit 2a21890 into orhun:main Apr 18, 2022
@favna favna deleted the patch-1 branch April 18, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants