Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support changing commit scope with commit_parsers #94

Merged
merged 8 commits into from
Jun 22, 2022

Conversation

ofsahof
Copy link
Contributor

@ofsahof ofsahof commented Jun 14, 2022

Description

I followed the instructions :)
Some new test cases are missing but I'll add as soon as possible

Motivation and Context

For overriding commit scope.

resolves #50

How Has This Been Tested?

Current tests are passing. New tests are missing.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ofsahof ofsahof requested a review from orhun as a code owner June 14, 2022 08:49
@orhun orhun changed the title fix: issue #50 Support changing the commit scope with commit_parsers Jun 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.15%. Comparing base (7d0786c) to head (3257618).
Report is 853 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff-core/src/commit.rs 50.00% 7 Missing and 2 partials ⚠️
git-cliff-core/src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   39.08%   40.15%   +1.08%     
==========================================
  Files          15       15              
  Lines         947      969      +22     
  Branches      249      252       +3     
==========================================
+ Hits          370      389      +19     
- Misses        453      456       +3     
  Partials      124      124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but looks good. Can you run cargo fmt and cargo clippy and update the code? Also, I think README.md could be updated about this change.

git-cliff-core/src/commit.rs Outdated Show resolved Hide resolved
git-cliff-core/src/commit.rs Outdated Show resolved Hide resolved
@orhun orhun changed the title Support changing the commit scope with commit_parsers feat(config): support changing commit scope with commit_parsers Jun 22, 2022
@orhun orhun merged commit e220768 into orhun:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change scope with commit_parsers
3 participants