Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the token from the access_token query parameter #156

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

janekolszak
Copy link
Contributor

As discussed on Gitter some time ago - fosite needs to use access_token query param. (https://tools.ietf.org/html/rfc6750)

@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage decreased (-0.3%) to 72.2% when pulling e81ae5b on janekolszak:master into 5e1c890 on ory:master.

@aeneasr
Copy link
Member

aeneasr commented Apr 11, 2017

Thank you for your contribution!

Unfortunately, the tests are failing. Most likely because req.URL.Query() has not been mocked properly in the tests. While you're add it, could you please add a test for query-based access token verification as well?

Also, could you please sign our DOC :)

@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage decreased (-3.4%) to 69.176% when pulling c98a6ed on janekolszak:master into 344dbef on ory:master.

@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage decreased (-3.4%) to 69.176% when pulling ba1d7f2 on janekolszak:master into 344dbef on ory:master.

@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage decreased (-3.4%) to 69.176% when pulling 9dc0b13 on janekolszak:master into 344dbef on ory:master.

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage decreased (-0.03%) to 72.54% when pulling 7aa20f1 on janekolszak:master into 344dbef on ory:master.

@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage increased (+0.1%) to 72.684% when pulling c974b42 on janekolszak:master into 344dbef on ory:master.

@aeneasr
Copy link
Member

aeneasr commented Apr 12, 2017

Let me know when you're ready for review :) Stupid coveralls...

@janekolszak
Copy link
Contributor Author

janekolszak commented Apr 12, 2017

It's ready.
I was lazy and tried to use CI for development. In the end had to setup test on my local env. 😸

I'm not sure about ParseForm. It seems to parse more than needed, but I can't find anything that parses only URL.

@aeneasr
Copy link
Member

aeneasr commented Apr 13, 2017

Perfect, thank you! Now one last thing, could you please sign the DOC with git commit --amend -s? :)

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.1%) to 72.684% when pulling 58cc0dc on janekolszak:master into 344dbef on ory:master.

@janekolszak
Copy link
Contributor Author

Done

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2017

Thank you!

@aeneasr aeneasr merged commit 9edac04 into ory:master Apr 14, 2017
budougumi0617 added a commit to budougumi0617/fosite that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants