Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uniform audience parsing #505

Merged
merged 3 commits into from
Oct 11, 2020
Merged

fix: Uniform audience parsing #505

merged 3 commits into from
Oct 11, 2020

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Oct 3, 2020

Proposed changes

Making sure audience parsing in authorize flow is the same as in access flow. Consistency.

Edit: I extended that with few other cases and made it consistent across the board. Also stringx.Splitx is not used anymore now because calling RemoveEmpty is equivalent (but does more).

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a regression test for this please?

@mitar
Copy link
Contributor Author

mitar commented Oct 7, 2020

Added test.

@mitar mitar requested a review from aeneasr October 7, 2020 03:39
@aeneasr
Copy link
Member

aeneasr commented Oct 11, 2020

Thank you for the great contributions this week, @mitar!

@aeneasr aeneasr merged commit e3f331d into ory:master Oct 11, 2020
@mitar mitar deleted the audience-parsing branch October 12, 2020 01:22
@mitar
Copy link
Contributor Author

mitar commented Oct 13, 2020

BTW, could you make a release sometime soon? So that I can update stuff on our side.

@aeneasr
Copy link
Member

aeneasr commented Oct 20, 2020

Sorry about the delay - it's done! By the way, you can reference git hashes and branches in go.mod so need to wait to wait for releases :)

@mitar
Copy link
Contributor Author

mitar commented Oct 20, 2020

I know, but it is cleaner to have versions. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants