Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade gogo protubuf #573

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Conversation

vineet-garg
Copy link
Contributor

Related issue

This should fix Nancy scan failure

Proposed changes

upgrade gogo/protobuf version

Checklist

  • [x ] I have read the contributing guidelines
    and signed the CLA.
  • [ x] I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@vineet-garg vineet-garg changed the title upgrade gogo/protubuf fix:upgrade gogo/protubuf Mar 29, 2021
@vineet-garg vineet-garg changed the title fix:upgrade gogo/protubuf fix: upgrade gogo/protubuf Mar 29, 2021
@vineet-garg vineet-garg changed the title fix: upgrade gogo/protubuf fix: upgrade gogo protubuf Mar 29, 2021
@vineet-garg vineet-garg marked this pull request as ready for review March 29, 2021 21:20
@vineet-garg
Copy link
Contributor Author

FYI: I did not edit the files in this commit. All I had to do was run a command go get github.com/gogo/[email protected] The changes made to the go.mod and go.sum files were automatic as a result of the above command.

@zepatrik
Copy link
Member

zepatrik commented Mar 30, 2021

I just updated the downstream package, can you also bump it? https://github.com/ory/x/releases/tag/v0.0.212
This should solve the problems in this repo.

@vineet-garg
Copy link
Contributor Author

I just updated the downstream package, can you also bump it? https://github.com/ory/x/releases/tag/v0.0.212
This should solve the problems in this repo.

Done

@aeneasr
Copy link
Member

aeneasr commented Mar 30, 2021

Thank you!

@aeneasr aeneasr merged commit 9a9467a into ory:master Mar 30, 2021
@vineet-garg vineet-garg deleted the fix_upgrade_gogo_protobuf branch March 30, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants