Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass requests through context #596

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

mitar
Copy link
Contributor

@mitar mitar commented May 15, 2021

Related issue

#537

Proposed changes

This PR adds to current context various requests and response structs so that it is easier to access them in methods which otherwise do not get them as an argument. This allows easier implementation of different interfaces.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

access_request_handler.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented May 19, 2021

🎉

@aeneasr aeneasr merged commit 2f96bb8 into ory:master May 19, 2021
narg95 pushed a commit to narg95/fosite that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants