feat: Use custom hash.Hash in hmac.HMACStrategy #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mash
changed the title
aeneasr
approved these changes
Apr 14, 2022
aeneasr
requested changes
Apr 14, 2022
| @@ -131,3 +132,17 @@ func TestValidateWithRotatedKeyInvalid(t *testing.T) { | |||
|
|
|||
| require.EqualError(t, new(HMACStrategy).Validate(token), "a secret for signing HMAC-SHA512/256 is expected to be defined, but none were") | |||
| } | |||
|
|
|||
| func TestCustomHMAC(t *testing.T) { | |||
There was a problem hiding this comment.
Could you please also add a success case? :)
aeneasr
approved these changes
Apr 15, 2022
|
Happy to be able to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Hash func() hash.Hashfield inhmac.HMACStrategyto allow using a customhash.Hashfunction. When nil, the defaultsha512.New512_256is used.Related Issue or Design Document
#654
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
appropriate).
Further comments