Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make health endpoints access logging configurable #1934

Conversation

landerss1
Copy link
Contributor

This PR introduces a new boolean configuration parameter that allows turning off logging of health endpoints requests in the access log. The implementation is basically a rip-off from Ory Hydra and the configuration parameter is the same:

serve.public.access_log.disable_for_health
serve.admin.access_log.disable_for_health

The default value is false.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Couldn't find any documentation to update, so if I'm missing anything, please direct me to the right place.

embedx/config.schema.json Outdated Show resolved Hide resolved
@@ -1388,6 +1398,16 @@
"public": {
"type": "object",
"properties": {
"access_log": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@aeneasr
Copy link
Member

aeneasr commented Nov 8, 2021

access_log was taken from ory hydra, if we change it to request_log, can you maybe update it in hydra too? :)

@aeneasr aeneasr merged commit 1301f68 into ory:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants