-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added phone number identifier #1938
Conversation
8da18d3
to
a93526f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good so far! How do you want to handle sending SMS?
Created a separate PR for sending sms (for easier review): #1941 |
a2d9cf1
to
1adabc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good on a high level (will need to dig into the tests still)! Could you also please add some docs for this feature, probably around here https://www.ory.sh/kratos/docs/concepts/email-sms#sending-sms?
this PR/features is awesome. we (https://github.com/GaloyMoney/galoy) will likely switch to Ory once this is done. |
Look forward to this update. Come on. |
This comment has been minimized.
This comment has been minimized.
Please follow our code of conduct and community guidelines and refrain from putting pressure on open source contributors. No one is preventing you from doing the work yourself and you have no right to try and force others to do it for you. Thank you. |
97f8f6f
to
09b9a82
Compare
adc267b
to
b913411
Compare
b913411
to
e4dc46f
Compare
Removed PR from draft status, added validation and test. Have one problem with failing docker image scanner, but it is related to protobuf package which was not changed in this PR (also you can check out anchore/grype#558, seems like this failing check is false-positive). @aeneasr please, review once again |
Yes, that is indeed a false positive. No problem. The e2e test is also flaky 😅 How would you like to continue with the other SMS PR that is going on? Do we merge this one, then rebase the other? I have time to review tomorrow :) |
Scanning over the code quickly, this looks good to merge 🎉 I will do another pass tomorrow but I think this is a no-brainer in terms of merging, great job :) |
Yep, I am finishing the pull request with the courier now - encountered a few errors |
Hello @alexey-reshetnik |
Added phone number identifier support for verification.
Related issue(s)
#137
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments