Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faq #2101

Merged
merged 13 commits into from
Jan 10, 2022
Merged

fix: faq #2101

merged 13 commits into from
Jan 10, 2022

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jan 4, 2022

The FAQ currently is outdated, see questions on SPAs and others.
This patch

  • moves the FAQ to the Debug & Help section
  • renames it to Tips & Troubleshooting
  • moves many of the questions to documents where they fit better, reformatted and with added information where needed.
  • also some other spelling/format fixes

PR in docusaurus-template to remove the FAQ there:
ory/docusaurus-template#87

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@vinckr vinckr marked this pull request as ready for review January 7, 2022 15:23
@aeneasr
Copy link
Member

aeneasr commented Jan 8, 2022

Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:

$ make format
$ git commit -a -m "styles: format code"
$ git push

Thank you!

@aeneasr aeneasr merged commit 311f906 into ory:master Jan 10, 2022
@vinckr vinckr deleted the faq-update branch January 10, 2022 11:10
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to click on submit... maybe you can open a follow up PR?

docs/docs/concepts/email-sms.md Show resolved Hide resolved
docs/docs/concepts/identity-schema.mdx Show resolved Hide resolved
Comment on lines 1160 to 1164
If multiple
[registration methods](../docs/self-service/flows/user-registration.mdx) are
configured, users may be redirected to a social login provider
to link the accounts after the email verification. To skip this link-up add the
session hook after the registration method (e.g. `password`):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that statement is true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The session hook will not skip the link up?
At least for the user who asked this, it solved the issue.
Should I revert this and test it before we add it?
It also seems like an edgecase...

@vinckr
Copy link
Member Author

vinckr commented Jan 10, 2022

Thanks a lot for the review @zepatrik, I will open a follow up PR.

@vinckr vinckr restored the faq-update branch January 10, 2022 12:45
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
This patch 
- moves the FAQ to the Debug & Help section
- renames it to Tips & Troubleshooting
- moves many of the questions to documents where they fit better, reformatted and with added information where needed.
- also some other spelling/format fixes

See also ory/docusaurus-template#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants