Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submitSelfServiceLoginFlowBody and submitSelfServiceSettingsFlowBody #2288

Conversation

KajsaEklof
Copy link

The type submitSelfServiceSettingsFlow do not include the SubmitSelfServiceSettingsFlowWithLookupMethodBody or SubmitSelfServiceSettingsFlowWithWebAuthnMethodBody. Similarly for the submitSelfServiceLoginFlow this does not include SubmitSelfServiceLoginFlowWithLookupSecretMethodBody or SubmitSelfServiceLoginFlowWithWebAuthnMethodBody.

Related issue(s)

I've created issue #2287 for this.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your changes. We auto-generate the openapi spec from comments in the code. Unfortunately your changes will be overridden by that. You have to adjust the comments.

@KajsaEklof
Copy link
Author

Ok, I will update this PR. Do I need to make the changes in the spec/api.json file?

@aeneasr aeneasr self-assigned this Mar 6, 2022
aeneasr added a commit that referenced this pull request Mar 6, 2022
@aeneasr aeneasr closed this in 5d70f9c Mar 7, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants