Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sensitive log value redaction text configurable #2321

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

aarmam
Copy link
Contributor

@aarmam aarmam commented Mar 18, 2022

This pull request introduces feature to configure sensitive log value redaction text. Current redaction text "Value is sensitive and has been redacted. To see the value set config key "log.leak_sensitive_values = true" or environment variable "LOG_LEAK_SENSITIVE_VALUES=true"." is too long and takes considerable amount of log space.

Related issue(s)

ory/x#482

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #2321 (d83c8a8) into master (2fa33e4) will decrease coverage by 0.39%.
The diff coverage is n/a.

❗ Current head d83c8a8 differs from pull request most recent head 15dd1f1. Consider uploading reports for the commit 15dd1f1 to get more accurate results

@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
- Coverage   76.92%   76.53%   -0.40%     
==========================================
  Files         318      318              
  Lines       17622    17150     -472     
==========================================
- Hits        13555    13125     -430     
+ Misses       3128     3091      -37     
+ Partials      939      934       -5     
Impacted Files Coverage Δ
x/provider.go 0.00% <0.00%> (-44.45%) ⬇️
selfservice/hook/session_destroyer.go 60.00% <0.00%> (-13.34%) ⬇️
selfservice/flow/login/hook.go 89.01% <0.00%> (-5.81%) ⬇️
selfservice/strategy/oidc/strategy_login.go 67.60% <0.00%> (-5.60%) ⬇️
cmd/courier/watch.go 68.96% <0.00%> (-3.45%) ⬇️
schema/errors.go 79.56% <0.00%> (-2.59%) ⬇️
ui/container/container.go 88.69% <0.00%> (-2.27%) ⬇️
selfservice/flow/registration/hook.go 84.15% <0.00%> (-2.05%) ⬇️
selfservice/flow/login/handler.go 80.48% <0.00%> (-1.79%) ⬇️
session/test/persistence.go 98.61% <0.00%> (-1.39%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa33e4...15dd1f1. Read the comment docs.

@aeneasr aeneasr merged commit 9b66e43 into ory:master Mar 20, 2022
harnash pushed a commit to Wikia/kratos that referenced this pull request Mar 28, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants