Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark width and height as required #2322

Merged
merged 1 commit into from
Mar 20, 2022
Merged

fix: mark width and height as required #2322

merged 1 commit into from
Mar 20, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 18, 2022

Closes ory/sdk#157

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #2322 (fad9ab4) into master (2fa33e4) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2322      +/-   ##
==========================================
- Coverage   76.92%   76.56%   -0.36%     
==========================================
  Files         318      318              
  Lines       17622    17150     -472     
==========================================
- Hits        13555    13131     -424     
+ Misses       3128     3087      -41     
+ Partials      939      932       -7     
Impacted Files Coverage Δ
ui/node/attributes.go 60.86% <ø> (ø)
x/provider.go 0.00% <0.00%> (-44.45%) ⬇️
selfservice/hook/session_destroyer.go 60.00% <0.00%> (-13.34%) ⬇️
selfservice/flow/login/hook.go 89.01% <0.00%> (-5.81%) ⬇️
selfservice/strategy/oidc/strategy_login.go 67.60% <0.00%> (-5.60%) ⬇️
schema/errors.go 79.56% <0.00%> (-2.59%) ⬇️
ui/container/container.go 88.69% <0.00%> (-2.27%) ⬇️
selfservice/flow/registration/hook.go 84.15% <0.00%> (-2.05%) ⬇️
selfservice/flow/login/handler.go 80.48% <0.00%> (-1.79%) ⬇️
selfservice/flow/settings/hook.go 72.80% <0.00%> (-1.23%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa33e4...fad9ab4. Read the comment docs.

@aeneasr aeneasr merged commit 37f2f22 into master Mar 20, 2022
@aeneasr aeneasr deleted the close-sdk-157 branch March 20, 2022 16:45
harnash pushed a commit to Wikia/kratos that referenced this pull request Mar 28, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deserialize ui nodes of type script
1 participant