-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add localName to smtp config #2445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 76.52% 76.47% -0.05%
==========================================
Files 316 316
Lines 17596 17600 +4
==========================================
- Hits 13465 13460 -5
- Misses 3197 3205 +8
- Partials 934 935 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Could you please add this new key to the documentation? :)
https://www.ory.sh/docs/kratos/concepts/email-sms#sending-e-mails-via-smtp
60d0e73
to
4524927
Compare
Thank! I've added some docs in ory/docs#810 |
Hello @sthh |
This PR introduces a new configuration
courier.smtp.local_name
that is passed to the SMTP dialer used in kratos courier.The config value is used in the SMTP HELO/EHLO command and was previously hardcoded to
localhost
.Some SMTP relays (e.g. Gmail) require a unique identifier during the HELO command and close the connection if a generic value like
localhost
is used. Therefore those SMTP relays can currently not be used with Kratos.See https://support.google.com/a/answer/2956491?product_name=UnuFlow&hl=en&visit_id=637871815371283723-3216367043&rd=1&src=supportwidget0&hl=en
Note that you may not be able to reproduce the bug with an Gmail SMTP relay, since Gmail does not close every connection. For us, it worked fine for some time before Gmail started to close the connections.
Related issue(s)
#2425
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments