-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make ID field in VerifiableAddress struct optional #2507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
+ Coverage 76.01% 76.57% +0.55%
==========================================
Files 318 317 -1
Lines 18507 17636 -871
==========================================
- Hits 14068 13504 -564
+ Misses 3488 3193 -295
+ Partials 951 939 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should fix the issue, as the ID cannot be se by the client.
@zepatrik |
Thank you! |
Hello @atreya2011 |
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
I have explained in detail regarding this issue over here: #2506