fix: correctly calculate expired_at timestamp for FlowExpired errors

[zepatrik]

As reported on slack:

I'm doing a verification flow, and if the flow is expired, it returns a message id#4070005, with an expired_at field available in the context. [...] According to text field, the flow is expired ~6 days ago, and the expired_at value I'm getting is in fact 'now + 6 days'.

I propose to deprecate the since field for API clients, as it obviously is pretty inaccurate (though not as noticeable by the end-user). Having consistency here makes more sense IMO.

[codecov]

Codecov Report

Merging #2836 (fd67524) into master (4aab5e0) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
- Coverage   75.91%   75.87%   -0.04%     
==========================================
  Files         302      302              
  Lines       17898    17824      -74     
==========================================
- Hits        13587    13524      -63     
+ Misses       3265     3262       -3     
+ Partials     1046     1038       -8     

Impacted Files	Coverage Δ
selfservice/strategy/code/strategy_recovery.go	69.69% <0.00%> (ø)
selfservice/strategy/link/strategy_recovery.go	62.71% <0.00%> (ø)
selfservice/strategy/link/strategy_verification.go	58.55% <0.00%> (ø)
cmd/clidoc/main.go	65.84% <100.00%> (ø)
selfservice/flow/error.go	100.00% <100.00%> (ø)
selfservice/flow/login/error.go	72.88% <100.00%> (ø)
selfservice/flow/recovery/error.go	81.03% <100.00%> (ø)
selfservice/flow/registration/error.go	69.84% <100.00%> (ø)
selfservice/flow/settings/error.go	77.47% <100.00%> (ø)
selfservice/flow/verification/error.go	78.84% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.