Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make courier.TemplateType an enum #2875

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #2875 (20a85ea) into master (9eeedc0) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 20a85ea differs from pull request most recent head 453ab3f. Consider uploading reports for the commit 453ab3f to get more accurate results

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   75.92%   75.90%   -0.03%     
==========================================
  Files         303      303              
  Lines       18249    18249              
==========================================
- Hits        13856    13852       -4     
- Misses       3326     3329       +3     
- Partials     1067     1068       +1     
Impacted Files Coverage Δ
courier/email_templates.go 68.42% <ø> (ø)
session/test/persistence.go 99.01% <0.00%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 65aeb0a into master Nov 8, 2022
@aeneasr aeneasr deleted the chore/templateTypeEnum branch November 8, 2022 15:16
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants