feat: store errors of courier message

[jonas-jonas]

BREAKING CHANGE: The /admin/courier/messages endpoint now uses keysetpagination instead.

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got the approval (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[aeneasr]

Looking pretty good already! I think that we will need to change this medium-term to an event-based stream on top of opentelemetry, but this is a good get-it-done patch :)

[jonas-jonas]

@aeneasr this is now ready for round two, but we need ory/x#640 to be merged before we merge this, just FYI.

[codecov]

Codecov Report

Merging #2914 (e1ce94f) into master (59c30b6) will decrease coverage by 0.02%.
The diff coverage is 81.02%.

@@            Coverage Diff             @@
##           master    #2914      +/-   ##
==========================================
- Coverage   76.20%   76.17%   -0.03%     
==========================================
  Files         308      309       +1     
  Lines       18943    19031      +88     
==========================================
+ Hits        14435    14497      +62     
- Misses       3391     3408      +17     
- Partials     1117     1126       +9     

Impacted Files	Coverage Δ
courier/courier_dispatcher.go	45.58% <27.27%> (-8.65%)	⬇️
courier/smtp.go	70.45% <66.66%> (+0.22%)	⬆️
persistence/sql/persister_courier.go	84.09% <82.05%> (-2.78%)	⬇️
courier/handler.go	90.00% <92.59%> (-1.90%)	⬇️
courier/message.go	69.56% <100.00%> (+2.89%)	⬆️
courier/message_dispatch.go	100.00% <100.00%> (ø)
courier/test/persistence.go	100.00% <100.00%> (ø)
persistence/sql/persister_session.go	83.18% <100.00%> (ø)
session/handler.go	67.94% <100.00%> (ø)
session/session.go	77.34% <100.00%> (+0.35%)	⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aeneasr]

Awesome!

[jonas-jonas]

@aeneasr since Kratos was released in the meantime, this is now a breaking change. I added the note to the PR description, FYI.

[aeneasr]

TY