-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't assume the login challenge to be a UUID #3317
Conversation
persistence/sql/migrations/sql/20230614000001000000_hydra_login_challenge_format.up.sql
Outdated
Show resolved
Hide resolved
97cb7f2
to
84d14ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #3317 +/- ##
==========================================
- Coverage 78.20% 78.12% -0.08%
==========================================
Files 325 325
Lines 21079 21080 +1
==========================================
- Hits 16484 16469 -15
- Misses 3370 3383 +13
- Partials 1225 1228 +3
|
d716e20
to
028f64e
Compare
persistence/sql/migratest/fixtures/login_flow/349c945a-60f8-436a-a301-7a42c92604f9.json
Show resolved
Hide resolved
persistence/sql/migratest/fixtures/registration_flow/ef18b06e-4700-4021-9949-ef783cd86be8.json
Show resolved
Hide resolved
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
a7eb0f9
to
ac1bbde
Compare
For compatibility with ory/hydra#3515, which now encodes the whole flow in the login challenge, we cannot further assume that the challenge is a UUID.
ac1bbde
to
794ac6a
Compare
Co-authored-by: Patrik <[email protected]>
persistence/sql/migrations/sql/20230614000001000000_hydra_login_challenge_format.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good. You could improve the SQL migration, right now it will probably cause some 500s when migrating.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments