Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't require method to be passkey in settings schema #3862

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (800f8f1) to head (3fb1fb1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
+ Coverage   78.04%   78.05%   +0.01%     
==========================================
  Files         360      360              
  Lines       25233    25205      -28     
==========================================
- Hits        19694    19675      -19     
+ Misses       4033     4027       -6     
+ Partials     1506     1503       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@aeneasr aeneasr merged commit 660f330 into master Apr 5, 2024
30 of 31 checks passed
@aeneasr aeneasr deleted the jonas-jonas/passkeySettingsSchemaFix branch April 5, 2024 10:05
@aeneasr
Copy link
Member

aeneasr commented Apr 5, 2024

Merging because the test failure was a timing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants