Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log subject and method #244

Closed
wants to merge 2 commits into from
Closed

Conversation

wndhydrnt
Copy link

Related issue

#242 @aeneasr

Proposed changes

This change adds the two fields "method" and "subject" as fields to the Logger in the decisions API endpoint as well as the proxy implementation.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Aug 19, 2019

Thank you, I'm not super happy with how the subject is being handled because we return it just for logging. Let me see if there's a more beautiful way to solve it :)

aeneasr added a commit that referenced this pull request Dec 17, 2019
Adds details such as the HTTP Method, User Agent, Subject, and other information to the logging output of both the reverse proxy and the decision API.

Closes #244
Closes #242
@aeneasr aeneasr closed this in #316 Dec 17, 2019
aeneasr added a commit that referenced this pull request Dec 17, 2019
Adds details such as the HTTP Method, User Agent, Subject, and other information to the logging output of both the reverse proxy and the decision API.

Closes #244
Closes #242
pike1212 pushed a commit to pike1212/oathkeeper that referenced this pull request Dec 18, 2019
Adds details such as the HTTP Method, User Agent, Subject, and other information to the logging output of both the reverse proxy and the decision API.

Closes ory#244
Closes ory#242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants