Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #250: Ignore query parameters to build payload for Keto engine #251

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

GuillaumeSmaha
Copy link
Contributor

Related issue

#250

Proposed changes

Ignore query parameters to build the payload for Keto engine like oathkeeper do to match rules:

if !c.MatchString(fmt.Sprintf("%s://%s%s", u.Scheme, u.Host, u.Path)) {

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the
    developer guide (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2019

CLA assistant check))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))
All committers have signed the CLA.

@GuillaumeSmaha
Copy link
Contributor Author

Hi @aeneasr, can you please review this ?.

@aeneasr
Copy link
Member

aeneasr commented Sep 10, 2019 via email

@GuillaumeSmaha
Copy link
Contributor Author

Oh ok. Sorry. Enjoy your vacation :)

@aeneasr
Copy link
Member

aeneasr commented Sep 10, 2019 via email

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2019

Awesome, thank you for your contribution and sorry for the wait time :)

@aeneasr aeneasr merged commit d0fc7f4 into ory:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants