cmd: Add option to disable access log for health endpoints #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an option to disable access log for health endpoints. This is especially helpful in environments like Kubernetes, where special preprocessing filters would be required otherwise.
hypnoglow
force-pushed
the
allow-disable-access-log-health
branch
from
3f3e3da
to
f838158
Compare
aeneasr
reviewed
Oct 24, 2019
| @@ -40,7 +40,17 @@ func runProxy(d driver.Driver, n *negroni.Negroni, logger *logrus.Logger) func() | |||
| Transport: proxy, | |||
| } | |||
|
|
|||
| n.Use(negronilogrus.NewMiddlewareFromLogger(logger, "oathkeeper-proxy")) | |||
| proxyLogger := negronilogrus.NewMiddlewareFromLogger(logger, "oathkeeper-proxy") | |||
There was a problem hiding this comment.
We are using a small helper for this in other projects:
github.com/ory/x/reqlog.NewMiddlewareFromLogger(logger, "oathkeeper-api").ExcludePaths(healthx.ReadyCheckPath, healthx.AliveCheckPath)
Which basically moves the health checks to "debug" output. It's tested etc so I would prefer using that here :)
aeneasr
added a commit
that referenced
this pull request
Dec 17, 2019
Remove health endpoints from the logs to make monitoring easier. Setting `log_level` to `trace` will show these calls. Closes #283
aeneasr
added a commit
that referenced
this pull request
Dec 17, 2019
Remove health endpoints from the logs to make monitoring easier. Setting `log_level` to `trace` will show these calls. Closes #283
pike1212
pushed a commit
to pike1212/oathkeeper
that referenced
this pull request
Dec 18, 2019
Remove health endpoints from the logs to make monitoring easier. Setting `log_level` to `trace` will show these calls. Closes ory#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This changeset adds an option to disable access log for health endpoints.
This is especially helpful in environments like Kubernetes, where
special preprocessing filters would be required otherwise.
Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
developer guide (if appropriate)
Further comments
The same idea and reasoning as in ory/hydra#1458