Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change viper provider to use method that load env vars correctly #317

Closed
wants to merge 1 commit into from
Closed

change viper provider to use method that load env vars correctly #317

wants to merge 1 commit into from

Conversation

pike1212
Copy link
Contributor

Related issue

#305

Proposed changes

Use new helper method

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the
    developer guide (if appropriate)

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2019

Hm, looks like this is causing an issue with the tests. Any ideas?

aeneasr added a commit that referenced this pull request Dec 18, 2019
@aeneasr
Properly merge env vars into pipeline configs
c3172d1 
Previously, some keys did not respect the values set in the environment variables.

Closes #305
Closes #317
@aeneasr aeneasr mentioned this pull request Dec 18, 2019
Merged
@aeneasr aeneasr closed this in #320 Dec 18, 2019
aeneasr added a commit that referenced this pull request Dec 18, 2019
@aeneasr
Properly merge env vars into pipeline configs (#320)
3e7936a 
Previously, some keys did not respect the values set in the environment variables.

Closes #305
Closes #317
pike1212 pushed a commit to pike1212/oathkeeper that referenced this pull request Dec 18, 2019
@aeneasr @pike1212
Properly merge env vars into pipeline configs (ory#320)
6b59512 
Previously, some keys did not respect the values set in the environment variables.

Closes ory#305
Closes ory#317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pike1212 @aeneasr