Switch to alpine Docker base-image #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this have a significant impact on the image size or cpu/memory usage at runtime? I'm asking because I like running oathkeeper as a sidecar container with my main service container. To me, the tiny footprint is a major feature. I noticed that you have a separate Dockerfile-alpine for hydra. Maybe that could be the way to go here as well? |
|
no
… On 18. Dec 2019, at 06:02, Thomas Lee ***@***.***> wrote:
Does this have a significant impact on the image size or cpu/memory usage at runtime?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Sorry, I didn't see the edit:
Yes, that's absolutely right and I've updated the PR accordingly! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312