Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docker compose file #324

Closed
aeneasr opened this issue Dec 27, 2019 · 3 comments
Closed

Clean up docker compose file #324

aeneasr opened this issue Dec 27, 2019 · 3 comments

Comments

@aeneasr
Copy link
Member

aeneasr commented Dec 27, 2019

The current docker-compose file is very outdated and should be updated or removed.

@KarthikNayak
Copy link
Contributor

Picking this up! Will update the compose file!

@KarthikNayak
Copy link
Contributor

@aeneasr I see that the Docker file doesn't contain the build instructions, instead the build instructions lay in the Makefile this also means that just running docker build . fails. Is this expected behavior?
If so, is it okay to move the build instruction to the Dockerfile ? This would get the docker-compose up and running.

@aeneasr
Copy link
Member Author

aeneasr commented Dec 30, 2019

Thank you @KarthikNayak ! Yeah right - please leave the current Docker Images as is! You can however add another Dockerfile named Dockerfile-dc with build instructions specifically for Docker Compose!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants