Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth intsropsection configurable timeout #370

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

pike1212
Copy link
Contributor

@pike1212 pike1212 commented Mar 4, 2020

Related issue

#310

Proposed changes

Make http timeouts configurable in the oauth2 introspector

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

@pike1212 pike1212 changed the title Configurable timeout feat: oauth intsropsection configurable timeout Mar 4, 2020
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, thank you! I have some ideas how to improve it.

.schemas/config.schema.json Outdated Show resolved Hide resolved
.schemas/config.schema.json Outdated Show resolved Hide resolved
.schemas/authenticators.oauth2_introspection.schema.json Outdated Show resolved Hide resolved
.schemas/config.schema.json Show resolved Hide resolved
.schemas/authenticators.oauth2_introspection.schema.json Outdated Show resolved Hide resolved
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aeneasr aeneasr merged commit 0a39511 into ory:master Mar 5, 2020
@hefekranz
Copy link
Contributor

hmm, I was trying to use this feature and it seems like this only works if pre_authorization is enabled?
Is there a specific reason for that?

https://github.com/pike1212/oathkeeper/blob/519dc8d25c48ff0cd39dcd4e05e69616126e0a26/pipeline/authn/authenticator_oauth2_introspection.go#L169

@aeneasr
Copy link
Member

aeneasr commented Apr 10, 2020

Yup, that's not correct - would you be open to fix this? :)

@hefekranz
Copy link
Contributor

sure, can do :)

@hefekranz hefekranz mentioned this pull request Apr 14, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants