Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Rule Id on malformed configuration error #383

Closed
hefekranz opened this issue Mar 23, 2020 · 1 comment
Closed

Log Rule Id on malformed configuration error #383

hefekranz opened this issue Mar 23, 2020 · 1 comment
Labels
feat New feature or request.
Milestone

Comments

@hefekranz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When having a big pile of rules and a single config error among them, it's pretty hard to figure out which one it is.

Describe the solution you'd like

I'd like to see the Id of the rule with the error in the logs.

Errorf("A rule uses a malformed configuration and all URLs matching this rule will not work. You should resolve this issue now.")

Describe alternatives you've considered

I used a fork to figure out which rules were flawed.
Additional context

I can push a PR if you are ok with that.

@aeneasr
Copy link
Member

aeneasr commented Mar 24, 2020

Totally makes sense! PRs appreciated!

@aeneasr aeneasr added the feat New feature or request. label Mar 24, 2020
@aeneasr aeneasr added this to the v0.37.0 milestone Mar 24, 2020
@aeneasr aeneasr closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants