Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass query parameters to the hydrators #479

Merged
merged 1 commit into from
Jul 10, 2020
Merged

feat: pass query parameters to the hydrators #479

merged 1 commit into from
Jul 10, 2020

Conversation

crabtree
Copy link
Contributor

@crabtree crabtree commented Jul 8, 2020

Related issue

#339

Proposed changes

Pass all query parameters from the original request URL to the hydrator request.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2020

CLA assistant check
All committers have signed the CLA.

@crabtree crabtree marked this pull request as ready for review July 8, 2020 00:14
@aeneasr aeneasr merged commit 48603a1 into ory:master Jul 10, 2020
@aeneasr
Copy link
Member

aeneasr commented Jul 10, 2020

Thank you!

@crabtree crabtree deleted the queryparams-support-hydrator branch October 12, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants