Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init introspect http client once #714

Merged
merged 3 commits into from
May 8, 2021

Conversation

pike1212
Copy link
Contributor

@pike1212 pike1212 commented May 3, 2021

Related issue

#712

Proposed changes

Only initializes oauth client once during config stage and doesn't initialize when creating new introspector.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@pike1212 pike1212 changed the title Bugfix/intro preauth client fix: init introspect http client once May 3, 2021
@pike1212
Copy link
Contributor Author

pike1212 commented May 3, 2021

It looks like the tests pass different configs to the same authenticator? Is that a valid situation when actually deploying though?

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution!

@aeneasr aeneasr merged commit e203ad1 into ory:master May 8, 2021
@aeneasr
Copy link
Member

aeneasr commented May 8, 2021

Shit, I merged this too soon. You cant cache the client for all the configs. Reverting.

@aeneasr
Copy link
Member

aeneasr commented May 8, 2021

You need one cache per config or else all configs have the same client

aeneasr added a commit that referenced this pull request May 8, 2021
aeneasr added a commit that referenced this pull request May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants