Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace transitive dependencies to dgrijalva/jwt-go #740

Closed
Tomasz-Smelcerz-SAP opened this issue Jun 4, 2021 · 1 comment
Closed

Replace transitive dependencies to dgrijalva/jwt-go #740

Tomasz-Smelcerz-SAP opened this issue Jun 4, 2021 · 1 comment

Comments

@Tomasz-Smelcerz-SAP
Copy link
Contributor

Tomasz-Smelcerz-SAP commented Jun 4, 2021

Is your feature request related to a problem? Please describe.

The go build tools report many transitive dependencies to a no longer maintained project: https://github.com/dgrijalva/jwt-go.
There are high-ranked security vulnerabilities in the dgrijalva/jwt-go, e.g: https://nvd.nist.gov/vuln/detail/CVE-2020-26160
Security scanning tools are complaining about the issue and it's hard to estimate it's impact - too many dependencies overall.

Describe the solution you'd like

For the time being, add this to go.mod:

replace github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.1+incompatible

Then, when fixed releases are available, bump the versions for projects that now still link to dgrijalva/jwt-go.
Once there are no longer any dependencies to dgrijalva/jwt-go, the "replace" line can be removed.

Describe alternatives you've considered

Additional context

This is security-related, but it's kind-of a version bump, that's why I am creating an open issue for that instead of contacting the security team.

@aeneasr
Copy link
Member

aeneasr commented Jun 8, 2021

PRs welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants