Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Introduce caching to Get* commands #8

Closed
aeneasr opened this issue Feb 3, 2020 · 1 comment
Closed

Introduce caching to Get* commands #8

aeneasr opened this issue Feb 3, 2020 · 1 comment
Assignees
@zepatrik
Labels
up for grab

Comments

@aeneasr
Copy link
Member

aeneasr commented Feb 3, 2020

Viper caused serious performance issues on ORY Oathkeeper ( ory/oathkeeper#346 ). This was partially resolved for ORY Oathkeeper in ory/oathkeeper#348 .

We should make use of the newly introduced configChangedAt key ( #7 ) to do caching right in this library.

To verify performance enhancements, benchmark tests should be created.
@aeneasr
Copy link
Member Author

aeneasr commented Feb 23, 2020

Resolved on master

@aeneasr aeneasr closed this as completed Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zepatrik zepatrik

Labels
up for grab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @zepatrik