Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Select rows for doing bulk operation like delete,copy and rename #22

Open
miladhashemi opened this issue Jun 27, 2020 · 12 comments · May be fixed by #23
Open

Multi Select rows for doing bulk operation like delete,copy and rename #22

miladhashemi opened this issue Jun 27, 2020 · 12 comments · May be fixed by #23
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@miladhashemi
Copy link

Is it possible to add multi select rows capability in file manager and do bulk operation for delete,copy,move?

Scenario

I select two rows(ctrl+leftClick) and click on delete button.

Expected Result

System returns an array of two pathes. finally delete them in an iterate manner.

@andersevenrud
Copy link
Member

This will require updates in two areas:

So it should be fairly simple to implement this

@andersevenrud andersevenrud added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 27, 2020
@andersevenrud andersevenrud linked a pull request Jun 27, 2020 that will close this issue
@andersevenrud
Copy link
Member

I've started on implementing this. Here's a sneak preview:

OS_js

Ref:

@miladhashemi
Copy link
Author

Actually I think beside gui, the VFS and Adapter needs to be changed too.
One part of problem is in osjs/gui that must select multiple rows, it seem you handled it.
Next step we need Adapter supports operations like delete on it.
Adapter operates on array of vfs.oject instead of single vfs.object.

@andersevenrud
Copy link
Member

The VFS does not need any changes The file manager can just use Promise.all to handle bulk operations.

andersevenrud added a commit that referenced this issue Jul 2, 2020
@andersevenrud
Copy link
Member

I believe I've made all of the appropriate changes to the filemanager application, and now need to finish up the ListView component changes and I can put out a beta on npm for testing :)

@miladhashemi
Copy link
Author

Oh, Thank U Andres. How can I test beta version? Is it on npm rep at moment?

@andersevenrud
Copy link
Member

I haven't published it onto npm yet as I'm not 100% done.

You can try this out by checking out the code locally.

@miladhashemi
Copy link
Author

miladhashemi commented Oct 4, 2020

I tested multiselect option,but didnt works.
Even readdir throws bellow warning message:

TypeError: files.map is not a function

Also throws bellow warning as i click on edit menu:

TypeError: items.some is not a function

for readfile throws bellow error:

Uncaught TypeError: data.forEach is not a function

@andersevenrud
Copy link
Member

I haven't looked at it myself, but I'm pretty sure this is because I made some changes in the master codebase, then remastered this branch which made some calls invalid.

I'll update this ASAP.

@andersevenrud andersevenrud self-assigned this Dec 24, 2020
@hello-smile6
Copy link

I haven't looked at it myself, but I'm pretty sure this is because I made some changes in the master codebase, then remastered this branch which made some calls invalid.

I'll update this ASAP.

Status?

@andersevenrud
Copy link
Member

Status?

I always follow up in issues with updates. As you can see, I haven't really found any time for this.

@ajmeese7
Copy link
Member

I tested multiselect option,but didnt works. Even readdir throws bellow warning message:

TypeError: files.map is not a function

Also throws bellow warning as i click on edit menu:

TypeError: items.some is not a function

for readfile throws bellow error:

Uncaught TypeError: data.forEach is not a function

@miladhashemi I had that same problem a little bit ago, before realizing that you also need to update your local code with the linked unmerged LiveView PR on the GUI repository. Once you have those changes synced you will no longer experience those error messages. The PR still isn't perfect, the functionality isn't entirely up to what was initially requested quite yet, but I am going to try to get this working on my implementation then add to the PR and get this feature fully supported.

ajmeese7 added a commit to ajmeese7/osjs-filemanager-application that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants