-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes Singular creates unknown coefficient fields, which make Oscar unhappy #3088
Comments
Here is another simple example. Lots of things are broken for prime fields of large characteristic:
|
Is there any progress on this issue. The workarounds in #3173 only cause other troubles and it seems that I will never get the tests to run there. |
it should be, as of last Wedesday(??) be fixed. We confirm and close. |
update: still open(ish), but making progress |
Status: fixed with master branch of Oscar, not fixed with released version of Oscar |
I can confirm the fix on e86fe09. |
Best illustrated with an example:
This happens, because for the construction of the Singular quotient ring we go via:
Oscar.jl/src/Rings/MPolyQuo.jl
Line 31 in 32b7e89
(this is the Singular quotient ring, of which the
coefficient_ring
is of theN_Unknown[...]
type.As a consequence, on the Singular side we don't have the identical coefficient ring, which yields problems like #3080.
This is ultimately a Singular.jl issue, but I guess here the issue gets more attention. I think the discussion in oscar-system/Singular.jl#187 (comment) and oscar-system/Singular.jl#336 is relevant.
One option is ditch the generic
N_Field
interface and just refuse to do anything with coefficient rings that cannot be handled by native Singular coefficient fields. In most cases we can transform the input to the appropriate type. For the rest we will throw a "sorry, can't do this" error. This is a rather drastic solution, but maybe the only realistic one given our manpower?Any thoughts @fieker @fingolfin @hannes14?
The text was updated successfully, but these errors were encountered: