Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supertype of mu.KLogger unresolved (org.slf4j.logger) #83

Closed
deepakyadav opened this issue Jul 26, 2019 · 6 comments
Closed

Supertype of mu.KLogger unresolved (org.slf4j.logger) #83

deepakyadav opened this issue Jul 26, 2019 · 6 comments

Comments

@deepakyadav
Copy link

Getting following error after upgrading to latest version:

Error:Kotlin: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class mu.KLogger, unresolved supertypes: org.slf4j.Logger

I think it is cause by following change while migrating to MPP:

compile "org.slf4j:slf4j-api:${extra["sl4j_version"]}"
implementation("org.slf4j:slf4j-api:${extra["sl4j_version"]}")

Because mu.KLogger extends org.slf4j.Logger,
we need to use api instead of implementation:
api("org.slf4j:slf4j-api:${extra["sl4j_version"]}")

@oshai
Copy link
Owner

oshai commented Jul 26, 2019

I think you're right. I will check and fix that.

@oshai oshai closed this as completed in 2cc96ae Jul 26, 2019
@oshai
Copy link
Owner

oshai commented Jul 26, 2019

Fixed in 1.7.2. Thanks for reporting!

@deepakyadav
Copy link
Author

Thanks for quick fix. Please publish the version 1.7.2 as well.

@oshai
Copy link
Owner

oshai commented Jul 26, 2019

Its released. Might take some time to show on maven central.

@1951FDG
Copy link

1951FDG commented Jun 2, 2021

Apparently io.github.microutils:kotlin-logging:1.12.5 also requires the following,implementation "org.slf4j:slf4j-api:$slf4j_version" in the project, for it to compile

@oshai
Copy link
Owner

oshai commented Jun 2, 2021

I plan to deprecate 1.x soon, so I don't plan fixing that. See #180 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants