added separate logger.exitOpt for optional return types. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing and loglevels consistently on Windows and Linux.
|
Updated. |
oshai
reviewed
Aug 7, 2019
Merged
oshai
added a commit
that referenced
this pull request
Aug 8, 2019
* fixing signature of exit * resolve issue with type on exit. Ensure tests handle line feeds, flushing and loglevels consistently on Windows and Linux. * updated spacing and added .editorconfig * revert line length to styleguide * fix tests
|
Merged with #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate function
exitOptfor when the return type is optional. It is a mess otherwhise.