Fix domain dn #341
Merged
Fix domain dn #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting EXTRA_DOCKER_RUN_FLAGS, for example to --loglevel debug the user will be able to debug tests for failure analyzis
This cleans up the list of container which have be run for tests completely.
This will check the perfect match between values given by user in LDAP_DOMAIN and LDAP_BASE_DN and make the container run fail if they do not match Test added to check this enforcement
|
@BertrandGouny this should prevent errors and/or gives more insight for cases like seen in #238, #172, #338 |
Added 2 more test cases to enforce proper behaviour
Call get_ldap_base_dn to detect failure very early
BertrandGouny
added a commit
that referenced
this pull request
Aug 1, 2019
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some minor additions/fixes