Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(template): Update deps used by the template #126

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented Jun 13, 2023

Pull Request description

  • Revisit and update deps in the template.
  • Mypy threw a hint in the pre-commit for the __init__.py file, I changed # type: ignore[attr-defined] to # mypy: disable-error-code="attr-defined".
  • The .bandit file was deleted incorrectly, I fixed this (it is possible that the function and the file should be deleted).

Solve #48

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved.

@Anavelyz Anavelyz requested a review from xmnlab June 13, 2023 03:58
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that @Anavelyz !

@xmnlab xmnlab merged commit b0d440f into osl-incubator:main Jun 13, 2023
@Anavelyz Anavelyz deleted the dep branch June 13, 2023 16:23
@github-actions
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants