Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): Fix the linter configuration #131

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Jun 15, 2023

Pull Request description

Fix the linter configuration for the project and the template.

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab
Copy link
Member Author

xmnlab commented Jun 16, 2023

@Anavelyz @ayeankit @YurelyCamacho if you have time, could you review this PR please?
thanks!

src/scicookie/logs.py Outdated Show resolved Hide resolved
@YurelyCamacho
Copy link
Collaborator

@xmnlab I don't see anything out of the ordinary, though I'm still trying to figure it all out. Thank you

@xmnlab
Copy link
Member Author

xmnlab commented Jun 16, 2023

thanks @YurelyCamacho @Anavelyz for the review.
I am merging it now, but if you see anything that could be improved. feel free to open an issue for that!

@xmnlab xmnlab merged commit e9843e2 into osl-incubator:main Jun 16, 2023
@xmnlab xmnlab deleted the fix-pre-commit-config-2 branch June 16, 2023 19:38
@github-actions
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants