Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variable name): Fix package's name #137

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

Anavelyz
Copy link
Collaborator

Pull Request description

The correct name in the pyproject.toml for build_system=flit is the value in project_slug.

Thank you for the catch @YurelyCamacho

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved.

@Anavelyz Anavelyz requested a review from xmnlab June 28, 2023 00:37
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Anavelyz !!

@xmnlab xmnlab merged commit 4066549 into osl-incubator:main Jun 28, 2023
YurelyCamacho pushed a commit to YurelyCamacho/cookiecutter-python that referenced this pull request Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants