Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for OR and AND for depends_on #295

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Jun 7, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab marked this pull request as ready for review June 7, 2024 22:31
@xmnlab
Copy link
Member Author

xmnlab commented Jun 7, 2024

@Anavelyz ,

I didn't add any specific test for this implementation .. but as the current tests worked .. I am merging this PR so you can move forward your task.

@xmnlab xmnlab merged commit a2ff8c7 into osl-incubator:main Jun 7, 2024
16 checks passed
@xmnlab xmnlab deleted the imp-depends-on branch June 7, 2024 22:33
Copy link

🎉 This issue has been resolved in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant