Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial latitude / longitude #26

Closed
chapulina opened this issue Aug 19, 2021 · 3 comments
Closed

Set initial latitude / longitude #26

chapulina opened this issue Aug 19, 2021 · 3 comments
Assignees

Comments

@chapulina
Copy link
Contributor

We're currently filling the lat/lon coordinates here:

https://github.com/osrf/lrauv/blob/39a08bbcf9acb3e6131c8c38b6d762f0532401ee/lrauv_ignition_plugins/src/TethysCommPlugin.cc#L448-L453

By default, that's considering the world origin to be at 0° / 0°.

We should be setting the correct initial lat/lon at startup so that subsequent queries get the position with respect to that. Here's an upstream issue for setting it from SDF: gazebosim/gz-sim#981

Here, instead of hardcoding it into the SDF, we may be able to subscribe to this message from LRAUV to get the initial values:

https://bitbucket.org/mbari/lrauv-application/src/master/Source/simulatorModule/SimInitStruct.h

@mabelzhang
Copy link
Collaborator

Wow, that SimInitStruct is humongous...

@braanan
Copy link
Collaborator

braanan commented Aug 20, 2021

Well yeah, it basically holds all the stuff we currently have in the add files..

@mabelzhang
Copy link
Collaborator

mabelzhang commented Aug 20, 2021

We could either have a full protobuf message with all those fields or just have a small one that we build up as needed.

@chapulina chapulina self-assigned this Sep 9, 2021
@chapulina chapulina transferred this issue from another repository Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants