From dd0f39829694c262c67cacd1d7a138c1356f00fa Mon Sep 17 00:00:00 2001
From: ChenGH <chengh_math@126.com>
Date: Mon, 2 Jan 2023 14:57:47 +0800
Subject: [PATCH] Asan: Disable asan for CentOS and use statically link if
 possible. v5.0.127 (#3347) (#3352)

* Asan: Disable asan for CentOS and use statically link if possible. v5.0.127 (#3347)

1. Disable asan for all CentOS by default, however user could enable it.
2. Link asan statically if possible.

* Update version to v5.0.127

Co-authored-by: winlin <winlin@vip.126.com>
---
 trunk/Dockerfile                     |  2 +-
 trunk/auto/depends.sh                | 13 ++++++++++++-
 trunk/auto/options.sh                |  9 ++++++++-
 trunk/configure                      |  5 -----
 trunk/doc/CHANGELOG.md               |  1 +
 trunk/src/core/srs_core_version5.hpp |  2 +-
 6 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/trunk/Dockerfile b/trunk/Dockerfile
index fac94ed29b..68c9c29738 100644
--- a/trunk/Dockerfile
+++ b/trunk/Dockerfile
@@ -29,7 +29,7 @@ WORKDIR /srs/trunk
 # Build and install SRS.
 # Note that SRT is enabled by default, so we configure without --srt=on.
 # Note that we have copied all files by make install.
-RUN ./configure --gb28181=on --sanitizer-static=on ${CONFARGS} && make ${MAKEARGS} && make install
+RUN ./configure --gb28181=on ${CONFARGS} && make ${MAKEARGS} && make install
 
 ############################################################
 # dist
diff --git a/trunk/auto/depends.sh b/trunk/auto/depends.sh
index 6a69e0c0c2..d5a5637688 100755
--- a/trunk/auto/depends.sh
+++ b/trunk/auto/depends.sh
@@ -117,7 +117,18 @@ if [[ $SRS_SANITIZER == YES && $OS_IS_X86_64 == YES ]]; then
     fi
 fi
 
-if [[ $SRS_SANITIZER == YES && $OS_IS_X86_64 == YES ]]; then
+if [[ $SRS_SANITIZER == YES && $OS_IS_X86_64 == YES && $SRS_SANITIZER_STATIC == NO ]]; then
+    echo 'int main() { return 0; }' > ${SRS_OBJS}/test_sanitizer.c &&
+    gcc -fsanitize=address -fno-omit-frame-pointer -static-libasan -g -O0 ${SRS_OBJS}/test_sanitizer.c \
+        -o ${SRS_OBJS}/test_sanitizer 1>/dev/null 2>&1;
+    ret=$?; rm -rf ${SRS_OBJS}/test_sanitizer*
+    if [[ $ret -eq 0 ]]; then
+        echo "link static-libasan"
+        SRS_SANITIZER_STATIC=YES
+    fi
+fi
+
+if [[ $SRS_SANITIZER == YES && $OS_IS_X86_64 == YES && $SRS_SANITIZER_LOG == NO ]]; then
     echo "#include <sanitizer/asan_interface.h>" > ${SRS_OBJS}/test_sanitizer.c &&
     echo "int main() { return 0; }" >> ${SRS_OBJS}/test_sanitizer.c &&
     gcc -fsanitize=address -fno-omit-frame-pointer -g -O0 ${SRS_OBJS}/test_sanitizer.c \
diff --git a/trunk/auto/options.sh b/trunk/auto/options.sh
index 220313f9c3..cd3a3b8b1a 100755
--- a/trunk/auto/options.sh
+++ b/trunk/auto/options.sh
@@ -68,7 +68,7 @@ SRS_LOG_LEVEL_V2=YES
 # Experts options.
 SRS_USE_SYS_SSL=NO # Use system ssl(-lssl) if required.
 SRS_VALGRIND=NO
-SRS_SANITIZER=YES
+SRS_SANITIZER=NO
 SRS_SANITIZER_STATIC=NO
 SRS_SANITIZER_LOG=NO
 SRS_BUILD_TAG= # Set the object files tag name.
@@ -503,6 +503,13 @@ function apply_auto_options() {
         SRS_FFMPEG_FIT=YES
     fi
 
+    # Enable asan, but disable for Centos
+    # @see https://github.com/ossrs/srs/issues/3347
+    if [[ $SRS_SANITIZER == NO && $OS_IS_CENTOS != YES ]]; then
+        echo "Enable asan by auto options."
+        SRS_SANITIZER=YES
+    fi
+
     # If enable gperf, disable sanitizer.
     if [[ $SRS_GPERF == YES && $SRS_SANITIZER == YES ]]; then
         echo "Disable sanitizer for gperf"
diff --git a/trunk/configure b/trunk/configure
index dc934ac350..dd197a05f2 100755
--- a/trunk/configure
+++ b/trunk/configure
@@ -197,11 +197,6 @@ if [[ $SRS_STATIC == YES ]]; then
     SrsLinkOptions="${SrsLinkOptions} -static-libstdc++";
 fi
 
-# For asan(Google Address Sanitizer)
-if [[ $SRS_SANITIZER == YES && $OS_IS_X86_64 == YES && $SRS_SANITIZER_STATIC == YES ]]; then
-    SrsLinkOptions="${SrsLinkOptions} -static-libasan";
-fi
-
 # For coverage.
 if [[ $SRS_GCOV == YES ]]; then
     SrsLinkOptions="${SrsLinkOptions} ${SrsGcov}";
diff --git a/trunk/doc/CHANGELOG.md b/trunk/doc/CHANGELOG.md
index 12c6f0780f..c690486032 100644
--- a/trunk/doc/CHANGELOG.md
+++ b/trunk/doc/CHANGELOG.md
@@ -8,6 +8,7 @@ The changelog for SRS.
 
 ## SRS 5.0 Changelog
 
+* v5.0, 2023-01-02, Fix [#3347](https://github.com/ossrs/srs/issues/3347): Asan: Disable asan for CentOS and use statically link if possible. v5.0.127
 * v5.0, 2023-01-01, For [#296](https://github.com/ossrs/srs/issues/296): MP3: Upgrade mpegts.js to support HTTP-TS with mp3. v5.0.126
 * v5.0, 2023-01-01, For [#3349](https://github.com/ossrs/srs/issues/3349): API: Fix duplicated on_stop callback event bug. v5.0.125
 * v5.0, 2022-12-31, GB28181: Enable regression test for gb28181. v5.0.122
diff --git a/trunk/src/core/srs_core_version5.hpp b/trunk/src/core/srs_core_version5.hpp
index ff4bcdf487..3dd3161413 100644
--- a/trunk/src/core/srs_core_version5.hpp
+++ b/trunk/src/core/srs_core_version5.hpp
@@ -9,6 +9,6 @@
 
 #define VERSION_MAJOR       5
 #define VERSION_MINOR       0
-#define VERSION_REVISION    126
+#define VERSION_REVISION    127
 
 #endif