Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add h264 sei filter configure #1631

Merged
merged 3 commits into from
Mar 7, 2020
Merged

add h264 sei filter configure #1631

merged 3 commits into from
Mar 7, 2020

Conversation

runner365
Copy link
Contributor

add h264 sei filter configure in srt2rtmp

@codecov-io
Copy link

codecov-io commented Mar 7, 2020 •
edited by winlinvip
Loading

Codecov Report

Merging #1631 into 3.0release will increase coverage by 15.54%.
The diff coverage is 3.38%.

Impacted file tree graph

@@               Coverage Diff               @@
##           3.0release    #1631       +/-   ##
===============================================
+ Coverage       53.05%   68.59%   +15.54%     
===============================================
  Files              82       96       +14     
  Lines           26520    40716    +14196     
===============================================
+ Hits            14069    27931    +13862     
- Misses          12451    12785      +334

| Impacted Files | Coverage Δ | |'

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_config.hpp | 100% <ø> (+100%) | ⬆️ |
| trunk/src/app/srs_app_server.cpp | 0% <ø> (ø) | ⬆️ |
| trunk/src/app/srs_app_rtsp.cpp | 0% <0%> (ø) | ⬆️ |
| trunk/src/protocol/srs_protocol_utility.cpp | 96.55% <100%> (ø) | ⬆️ |
| trunk/src/protocol/srs_rtmp_stack.cpp | 89.48% <100%> (ø) | ⬆️ |
| trunk/src/app/srs_app_config.cpp | 77.91% <2.29%> (-3.74%) | ⬇️ |
| trunk/src/app/srs_app_hybrid.cpp | 2.81% <2.81%> (ø) | |
| trunk/src/utest/srs_utest_app.cpp | 100% <0%> (ø) | |
| trunk/src/utest/srs_utest_reload.cpp | 94.53% <0%> (ø) | |
| ... and 15 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bbf84...a2839aa. Read the comment docs.

TRANS_BY_GPT3

@winlinvip winlinvip changed the base branch from 3.0release to 4.0release March 7, 2020 14:17
@winlinvip winlinvip merged commit 82824ba into ossrs:4.0release Mar 7, 2020
@winlinvip winlinvip mentioned this pull request Mar 7, 2020
Closed
winlinvip added a commit that referenced this pull request Mar 7, 2020
@winlinvip
For #1631, support sei_filter for SRT. 4.0.11
41acf9c
winlinvip
winlinvip reviewed Mar 7, 2020
View reviewed changes
trunk/src/srt/srt_to_rtmp.cpp
@@ -459,6 +459,12 @@ srs_error_t rtmp_client::on_ts_video(std::shared_ptr<SrsBuffer> avs_ptr, uint64_
if (nal_unit_type == SrsAvcNaluTypeAccessUnitDelimiter) {
continue;
}

if (_srs_config->get_srt_sei_filter()) {
Copy link
Member

@winlinvip winlinvip Mar 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the config for every video frame may pose certain risks. It is recommended to cache this configuration at the rtmp_client level and update it if necessary using reload.

TRANS_BY_GPT3

@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winlinvip winlinvip winlinvip left review comments

Assignees
No one assigned
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runner365 @codecov-io @winlinvip