KERNEL: Software Consistency and Conceptual Integrity Issues

[winlinvip]

https://github.com/winlinvip/simple-rtmp-server/issues/288

TRANS_BY_GPT3

[winlinvip]

#786
Maintain a simple constructor, support empty object behavior, and use non-reusable objects to simplify logic.

TRANS_BY_GPT3

[winlinvip]

#742 Refactor introduced due to possible race conditions in SrsSource, including:

1. Always enable kernel features, there is no need to provide compile switches for core features, they should be enabled by default. Disabling core features can affect some functionalities and make them incomplete.
2. About the CID, regarding the integrity of concepts such as connection ID, context ID, or client ID.
3. Origin HUB, certain functionalities like DVR, HLS, and Transcode are only available at the source station. However, after triggering RTMP backhaul at the edge, Source can also use these functionalities, but they are incomplete. For example, if HLS is configured at the edge, accessing HLS at the edge will not have any slices. HLS slices will only be available when accessing RTMP. Therefore, this concept is incomplete. The functionalities exclusive to the source station are placed in OriginHUB, and only the source station SrsSource will have them.
4. Timebase in ms, for streaming media, millisecond-based timestamps are sufficient. However, ST uses microsecond-based timestamps, so some places use milliseconds while others use microseconds. It should be unified to milliseconds.
5. Never reuse object, in general, objects should not be reused because reusing them requires considering more states. Only objects like threads that need to be restarted may be reused. In general, reusing objects is not necessary and can simplify a lot of logic. On the contrary, if reuse is provided, sometimes the complete concept of reuse cannot be used, and only a part of it is used (not stopping in the destructor will automatically stop), or in other words, in most cases, reusing objects is not necessary.
6. Use simplest constructor, keep the constructor simple. Otherwise, in cases where certain interfaces require the object to be effective after construction, such as TcpClient returning recv_bytes immediately after construction (it is acceptable to return 0 if no bytes are received without connecting), it may limit the meaning and concept of other interfaces. Please refer to the description in this issue for more details.

TRANS_BY_GPT3

[winlinvip]

#820 Because many classes in the APP are used for the SRS server, while most of the Modules programs are not server programs but based on ST, it is necessary to abstract a Service module specifically for Modules to use. For example, config should not be included in this module because config is the configuration object of the SRS server.

TRANS_BY_GPT3

[winlinvip]

#906 There are too many thread classes, they should not be mixed with specific business logic. Threads should decide for themselves whether to loop or not, and the kernel only needs to provide the most typical thread logic.

TRANS_BY_GPT3

[winlinvip]

Some issues need to be fixed:

• How to authenticate HTTP FLV streaming? #910 FLV authentication.
• #741 Support URI for RTMP.
• #665 FLV reload http_remux.
• PROTOCOL: Support both FLV and TS #554 Support multiple HTTP remuxer.
• Http callback on_play support RTMP/HLS/HTTP-FLV #52 HTTP callback for FLV.

[winlinvip]

Fixed in SRS3.