Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary null pointer checks #3331

Closed
elfring opened this issue Dec 23, 2022 · 3 comments
Closed

Remove unnecessary null pointer checks #3331

elfring opened this issue Dec 23, 2022 · 3 comments
Assignees
@winlinvip
Labels
Enhancement Improvement or enhancement. good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.
Milestone
5.0

Comments

@elfring
Copy link

elfring commented Dec 23, 2022 •
edited by winlinvip
Loading

💭 An extra null pointer check is not needed in macros like "srs_freep" and "srs_freepa".

TRANS_BY_GPT3
@winlinvip winlinvip self-assigned this Dec 24, 2022
@winlinvip
Copy link
Member

winlinvip commented Dec 24, 2022 •
edited
Loading

Sounds good! Would you please file a PR?

@winlinvip winlinvip added Enhancement Improvement or enhancement. good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed labels Dec 25, 2022
@winlinvip winlinvip added this to the 5.0 milestone Dec 25, 2022
@yashwardhan-jyani
Copy link
Contributor

Hey @winlinvip , i fixed the issue and submitted a PR on this!

@winlinvip
Copy link
Member

Fixed by #3477

@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
Enhancement Improvement or enhancement. good first issue Easy to fix issues, good for newcomers help wanted Extra attention is needed TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
3 participants
@elfring @winlinvip @yashwardhan-jyani