Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse Everything cloud files add not working #2215

Closed
simholt opened this issue Mar 18, 2021 · 2 comments · Fixed by #2275
Closed

Browse Everything cloud files add not working #2215

simholt opened this issue Mar 18, 2021 · 2 comments · Fixed by #2275
Assignees
Labels
Bug Priority: High These are issues that should be prioritized for upcoming development efforts

Comments

@simholt
Copy link
Contributor

simholt commented Mar 18, 2021

Descriptive summary

User selects a file to attach but it never closes out so the is user stuck with the pop-up window.
@wickr was able to make it work by deleting the elements for the Browse Everything modal dialogs w/in the browser.

Expected behavior

User selects Add cloud files on the Files tab, chooses appropriate files, clicks Submit, then the file is attached.

Actual behavior

User selects Add cloud files, chooses files, and then is stuck with the window. Attachment does not appear to complete, cancel says it works but doesn't and user has to close window to escape.

Steps to reproduce the behavior

  1. Go to edit on any existing work and click on Files tab.
  2. Add cloud files.
  3. Choose file.
@simholt simholt added Bug Priority: High These are issues that should be prioritized for upcoming development efforts labels Mar 18, 2021
@wickr
Copy link
Member

wickr commented Mar 19, 2021

Browse Everything is working but not closing after clicking Submit (or Cancel).
The workaround is to manually delete the elements for the modal and the spinner, which returns control to Hyrax, and then one can submit the new file to attach.

  1. Select file(s) in Browse Everything dialog modal
  2. click Submit
  3. Modal says 100% complete, but does not close
  4. Use Developer Tools. In Chrome, right-click on dialog modal, click Inspect
  5. Make sure the dialog is highlighted, look up a few levels for the parent browse-everything element/code: <div tabindex="-1" id="browse-everything" ..., and right-click on that line and select 'Delete Element'
  6. That should close both the modal and the spinner, and the selected file can then be submitted as expected

@simholt
Copy link
Contributor Author

simholt commented Jul 20, 2021

Was able to attach test file without getting stuck, is listed on show page. QA pass--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Priority: High These are issues that should be prioritized for upcoming development efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants